Skip to content

Basic implementation of typedef member lookups #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jcollins-g
Copy link
Contributor

Further implementation of #2655.

With constructor tearoffs I can imagine it may be more common to want to link to a constructor while also indicating specific type parameters (even if Dartdoc ignores them). That'll be in a follow up, this PR only handles the easy case.

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Aug 30, 2021
@jcollins-g jcollins-g changed the title Basic implementation of typedef lookups Basic implementation of typedef member lookups Aug 30, 2021
@jcollins-g jcollins-g requested a review from srawlins August 30, 2021 23:27

/// A typedef referring to a non-function typedef that is nevertheless not
/// referring to a defined class. An example is a typedef alias for `void` or
/// for `Function` itself.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeesh, bizarre cases.

@jcollins-g jcollins-g merged commit 348cbd7 into dart-lang:master Aug 30, 2021
@jcollins-g jcollins-g deleted the constructor-tearoffs-typedefimpl branch August 30, 2021 23:44
dart-bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 31, 2021
… tearoffs.

The version is intended to match up with dart-lang/dartdoc#2768.

Change-Id: Ibe32cda1b6743bc17faf559486cca6f057977408
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/211960
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Janice Collins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants